This avoids a warning in python3 about the unclosed file
and potential side effects of the open file.
Close temp file following rec2csv_bad_shape test to avoid warning in …
Shouldn't it close when the object goes out of scope anyway? I don't see any harm in including this code (the ValueError exception should still bubble up to nose). I just wanted to make sure I understood tempfile correctly.
If this is a fix for python3, shouldn't it go against master rather than 1.1.x, which doesn't support python3?
Well I can rebase it against master and thats fine with me, but I believe the behavior is the same on the different python versions the only difference is that python 3 gives the not closed warning while python2 does not, thus it seems like a good idea to close the temp file in any case.
I think the tempfile is closed when it goes out of scope but I think the main point is that the file is destroyed when it is closed. http://docs.python.org/library/tempfile.html
In any case, explicit is better than implicit. I am fine with it being merged in.