Fix sankey.py pep8 and py3 compatibility #973

Merged
merged 3 commits into from Jul 18, 2012

Conversation

Projects
None yet
4 participants
Contributor

cgohlke commented Jun 30, 2012

No description provided.

Member

pelson commented Jun 30, 2012

I've gone through these changes and they are fine. I have made similar stylistic improvements in the past, but we do need to be careful in making large scale changes to files whilst we have the v1.1.x branch in a non-frozen state (see #910).

This gets my +1.

Contributor

cgohlke commented Jun 30, 2012

That's a good point (making large scale changes). This could wait until after 1.1.1.

Member

pelson commented Jun 30, 2012

This could wait until after 1.1.1.

Lets do that. That is a whole other issue which I intend to bring up in the next couple of days :-)

Owner

mdboom commented Jul 1, 2012

I agree about holding off on this until the 1.1.1 release.

It might also be nice, if possible, to separate out the actual fixes for Python 3 from the general PEP8 stuff.

Member

WeatherGod commented Jul 18, 2012

Now that v1.1.1 is out, would it be safe to get this merged in?

Member

pelson commented Jul 18, 2012

@WeatherGod: If your happy with the changes too, then I would say nothing.

Member

WeatherGod commented Jul 18, 2012

ok, merging....

WeatherGod merged commit 11567bb into matplotlib:master Jul 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment