Fix embedding_in_qt4_wtoolbar.py on Python 3 #976

Merged
merged 1 commit into from Jul 22, 2012

Conversation

Projects
None yet
4 participants
@cgohlke
Contributor

cgohlke commented Jun 30, 2012

No description provided.

@pelson

This comment has been minimized.

Show comment Hide comment
@pelson

pelson Jun 30, 2012

Member

+1. Tested it works with 2.6?

Member

pelson commented Jun 30, 2012

+1. Tested it works with 2.6?

@cgohlke

This comment has been minimized.

Show comment Hide comment
@cgohlke

cgohlke Jun 30, 2012

Contributor

Not tested with 2.6 and 2.7 yet.

Contributor

cgohlke commented Jun 30, 2012

Not tested with 2.6 and 2.7 yet.

@WeatherGod

This comment has been minimized.

Show comment Hide comment
@WeatherGod

WeatherGod Jul 18, 2012

Member

It "works" in 2.7, but I wonder if this example needs an overhaul. The toolbar is placed at the bottom, which doesn't seem to be the default location anymore for Qt4Agg. Also, the display of the cursor coordinates in the corner only works for a brief period before it only shows empty quotes.

Member

WeatherGod commented Jul 18, 2012

It "works" in 2.7, but I wonder if this example needs an overhaul. The toolbar is placed at the bottom, which doesn't seem to be the default location anymore for Qt4Agg. Also, the display of the cursor coordinates in the corner only works for a brief period before it only shows empty quotes.

@pelson

This comment has been minimized.

Show comment Hide comment
@pelson

pelson Jul 18, 2012

Member

Is that a regression as a result of this PR? If not, I would suggest merging this and opening an issue (If @cgohlke is ready and willing to be an assignee, that would be even better :-) )

Member

pelson commented Jul 18, 2012

Is that a regression as a result of this PR? If not, I would suggest merging this and opening an issue (If @cgohlke is ready and willing to be an assignee, that would be even better :-) )

@WeatherGod

This comment has been minimized.

Show comment Hide comment
@WeatherGod

WeatherGod Jul 18, 2012

Member

Looks like it is not a regression. The current version of the script also have the same problems.

Member

WeatherGod commented Jul 18, 2012

Looks like it is not a regression. The current version of the script also have the same problems.

efiring added a commit that referenced this pull request Jul 22, 2012

Merge pull request #976 from cgohlke/patch-12
Fix embedding_in_qt4_wtoolbar.py on Python 3

@efiring efiring merged commit 63e406b into matplotlib:master Jul 22, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment