Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix basic_units.py on Python 3. PEP8 and PyLint cleanup. #980

Merged
merged 2 commits into from Jul 17, 2012

Conversation

Projects
None yet
2 participants
Contributor

cgohlke commented Jun 30, 2012

No description provided.

@pelson pelson commented on an outdated diff Jun 30, 2012

examples/units/basic_units.py
@@ -235,21 +246,23 @@ def get_conversion_fn(self, unit):
return self.conversions[unit]
def convert_value_to(self, value, unit):
- #print 'convert value to: value ="%s", unit="%s"'%(value, type(unit)), self.conversions
+ #print 'convert value to: value ="%s", unit="%s"'%(value, type(unit)),
+ #self.conversions
@pelson

pelson Jun 30, 2012

Member

This changes the meaning if the print statement is uncommented. Could just remove the print statement...

@pelson pelson commented on the diff Jun 30, 2012

examples/units/basic_units.py
self.proxy_target = self.value
- def get_compressed_copy(self, mask):
@pelson

pelson Jun 30, 2012

Member

Where has this gone?

@cgohlke

cgohlke Jun 30, 2012

Contributor

It was a duplicate.

@pelson

pelson Jun 30, 2012

Member

I guess it is just an example, and if its not used in the example, then its not actually needed...

@pelson

pelson Jun 30, 2012

Member

ok. thanks.

Member

pelson commented Jun 30, 2012

+1

Member

pelson commented Jul 17, 2012

Thanks @cgohlke we share a common interest in being picky about whitespace/trying to make PyLint happy :-)

pelson added a commit that referenced this pull request Jul 17, 2012

Merge pull request #980 from cgohlke/patch-16
Fix basic_units.py on Python 3. PEP8 and PyLint cleanup.

@pelson pelson merged commit 1418e4a into matplotlib:master Jul 17, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment