Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply async-await form #49

Merged
merged 18 commits into from Apr 11, 2019

Conversation

Projects
None yet
3 participants
@d3m3vilurr
Copy link
Contributor

commented Mar 1, 2019

these codeset isn't tested yet.

d3m3vilurr added some commits Mar 1, 2019

@d3m3vilurr d3m3vilurr force-pushed the d3m3vilurr:async-await branch from ea92c74 to 44d8f92 Mar 1, 2019

d3m3vilurr added some commits Mar 1, 2019

@d3m3vilurr d3m3vilurr force-pushed the d3m3vilurr:async-await branch from 44d8f92 to fab5390 Mar 1, 2019

@AndrewJDR

This comment has been minimized.

Copy link
Collaborator

commented Mar 4, 2019

I am bravely testing this on one of my bridges :)
So far, just noticed a missing await (which did cause an issue -- I added a note in the code review above). Will keep an eye out for other problems.

Show resolved Hide resolved src/base.js Outdated
@AndrewJDR
Copy link
Collaborator

left a comment

I added the missing await and pushed it to the branch from my end. So this is ready for more testing.
(I'll continue testing it on my end)

@AndrewJDR

This comment has been minimized.

Copy link
Collaborator

commented Mar 4, 2019

Another person should test this, maybe @thomas-profitt ?

@d3m3vilurr

This comment has been minimized.

Copy link
Contributor Author

commented Mar 4, 2019

Thank you fix my mistake 👍

@thomas-profitt

This comment has been minimized.

Copy link
Member

commented Mar 7, 2019

I'm testing this in "production" now. I'll give it a few days.

@d3m3vilurr d3m3vilurr changed the title [WIP] Apply async-await form Apply async-await form Mar 10, 2019

@d3m3vilurr

This comment has been minimized.

Copy link
Contributor Author

commented Mar 10, 2019

least 3 people tested. imo nobody test to generate registration.yml but it would be work.

@thomas-profitt thomas-profitt merged commit 8a8cea3 into matrix-hacks:master Apr 11, 2019

@d3m3vilurr d3m3vilurr deleted the d3m3vilurr:async-await branch Apr 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.