Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement /messages on the CS API #591

Open
wants to merge 20 commits into
base: master
from

Conversation

Projects
None yet
1 participant
@babolivier
Copy link
Member

commented Nov 8, 2018

Working implementation using both the local database and backfill.

Requires matrix-org/gomatrixserverlib#101

Also, sorry for the massive PR, I realised the size it was going to have way too late.

babolivier added some commits Nov 8, 2018

Export streamEvents
This makes it easier to handle stream positions at other places in the sync api component.
Retrieval of local messages
Rough outline with debug logging and no comment

@babolivier babolivier requested a review from matrix-org/dendrite-core Nov 8, 2018

@babolivier

This comment has been minimized.

Copy link
Member Author

commented Nov 8, 2018

Will work on making travis-ci happy first thing tomorrow morning.

@babolivier

This comment has been minimized.

Copy link
Member Author

commented Nov 9, 2018

All other errors are build/linter errors due to matrix-org/gomatrixserverlib#101 not being merged yet, so I'll wait till it is merged to fix the remaining issues.

@babolivier babolivier force-pushed the babolivier/cs-messages branch from c6327a2 to 87748a8 Nov 12, 2018

babolivier added some commits Nov 12, 2018

Implement the use of new pagination tokens in /messages
Also use them to store and retrieve events we got from backfilling

@babolivier babolivier force-pushed the babolivier/cs-messages branch from 43dfe21 to 89aeb21 Nov 12, 2018

babolivier added some commits Nov 13, 2018

@babolivier

This comment has been minimized.

Copy link
Member Author

commented Dec 13, 2018

ftr I think I'll just keep this one open until I'm sure I'm done with it, in order to keep track of the state of the implementation, then close it and split it into separate, smaller PRs.

@erikjohnston erikjohnston removed the request for review from matrix-org/dendrite-core Apr 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.