Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build conflict between docker environment and host - #596 #598

Merged
merged 1 commit into from Mar 4, 2019

Conversation

@Cnly
Copy link
Collaborator

commented Jan 6, 2019

This PR isolates the pkg and bin directories inside the docker build environment from the host environment.

Before these changes, because golang:alpine3.6 may have a different version of go from that of the host environment and some different shared libraries, unexpected errors may occur when dendrite is built or when the binaries are run, for example object is [linux amd64 go1.11 X:framepointer] expected [linux amd64 go1.9.4 X:framepointer] and /build/bin/generate-keys: No such file or directory.

This should fix #596.

Signed-off-by: Alex Chen minecnly@gmail.com

Fix build conflict between docker environment and host - #596
Signed-off-by: Alex Chen <minecnly@gmail.com>
@anoadragon453
Copy link
Member

left a comment

This seems to work for me.

@babolivier
Copy link
Member

left a comment

lgtm

@anoadragon453 anoadragon453 merged commit 5d2d048 into matrix-org:master Mar 4, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.