Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data races reported by go test -race ./... #748

Merged
merged 4 commits into from Jul 25, 2019

Conversation

@Cnly
Copy link
Collaborator

commented Jul 18, 2019

Signed-off-by: Alex Chen minecnly@gmail.com

Pull Request Checklist

  • I have added any new tests that need to pass to testfile as specified in docs/sytest.md
  • Pull request includes a sign off
Fix data races reported by go test -race ./...
Signed-off-by: Alex Chen <minecnly@gmail.com>

Cnly added some commits Jul 18, 2019

Add a comment to fetchUserStream about locking
Signed-off-by: Alex Chen <minecnly@gmail.com>
Fix linting
Signed-off-by: Alex Chen <minecnly@gmail.com>
@anoadragon453
Copy link
Member

left a comment

lgtm!

@Cnly Cnly merged commit e66933b into matrix-org:master Jul 25, 2019

8 checks passed

buildkite/dendrite Build #140 passed (3 minutes, 19 seconds)
Details
buildkite/dendrite/build-slash-go-1-dot-11 Passed (59 seconds)
Details
buildkite/dendrite/build-slash-go-1-dot-12 Passed (1 minute, 2 seconds)
Details
buildkite/dendrite/lint-slash-go-1-dot-12 Passed (1 minute, 59 seconds)
Details
buildkite/dendrite/pipeline Passed (10 seconds)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-11 Passed (1 minute, 9 seconds)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-12 Passed (1 minute, 4 seconds)
Details
ci/circleci: dendrite Your tests passed on CircleCI!
Details

@Cnly Cnly added the maintenance label Aug 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.