Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "full_state" query parameter for /sync #751

Merged
merged 7 commits into from Aug 1, 2019

Conversation

@Cnly
Copy link
Collaborator

commented Jul 18, 2019

Closes #637.

Linting issues about constants here are fixed by #752.

Signed-off-by: Alex Chen minecnly@gmail.com

Pull Request Checklist

  • I have added any new tests that need to pass to testfile as specified in docs/sytest.md
  • Pull request includes a sign off

Cnly added some commits Jul 18, 2019

Implement "full_state" query parameter for /sync
Closes #637.

Signed-off-by: Alex Chen <minecnly@gmail.com>
Add newly passing test
Signed-off-by: Alex Chen <minecnly@gmail.com>
Fix too high complexity for getStateDeltas
Signed-off-by: Alex Chen <minecnly@gmail.com>

@Cnly Cnly marked this pull request as ready for review Jul 19, 2019

@Cnly Cnly requested a review from anoadragon453 Jul 19, 2019

@anoadragon453 anoadragon453 added this to In progress in Homeserver Task Board via automation Jul 25, 2019

@anoadragon453 anoadragon453 moved this from In progress to Community PRs in Homeserver Task Board Jul 25, 2019

@anoadragon453
Copy link
Member

left a comment

lgtm, just some very tiny nits, and linting needs to be fixed as well.

syncapi/storage/syncserver.go Outdated Show resolved Hide resolved
syncapi/storage/syncserver.go Outdated Show resolved Hide resolved

Cnly and others added some commits Jul 31, 2019

Apply suggestions from code review
Co-Authored-By: Andrew Morgan <1342360+anoadragon453@users.noreply.github.com>
Merge branch 'master' into sync-full-state
Signed-off-by: Alex Chen <minecnly@gmail.com>

@Cnly Cnly merged commit 3578d77 into matrix-org:master Aug 1, 2019

8 checks passed

buildkite/dendrite Build #168 passed (5 minutes, 26 seconds)
Details
buildkite/dendrite/build-slash-go-1-dot-11 Passed (1 minute, 3 seconds)
Details
buildkite/dendrite/build-slash-go-1-dot-12 Passed (1 minute)
Details
buildkite/dendrite/lint-slash-go-1-dot-12 Passed (1 minute, 55 seconds)
Details
buildkite/dendrite/pipeline Passed (9 seconds)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-11 Passed (1 minute, 1 second)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-12 Passed (56 seconds)
Details
ci/circleci: dendrite Your tests passed on CircleCI!
Details

Homeserver Task Board automation moved this from Community PRs to Done Aug 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.