Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement room creation content #754

Merged
merged 5 commits into from Jul 24, 2019

Conversation

@Cnly
Copy link
Collaborator

commented Jul 22, 2019

Fixes #660.

Signed-off-by: Alex Chen minecnly@gmail.com

Pull Request Checklist

  • I have added any new tests that need to pass to testfile as specified in docs/sytest.md
  • Pull request includes a sign off
Implement room creation content - fixes #660
Signed-off-by: Alex Chen <minecnly@gmail.com>

@Cnly Cnly requested a review from anoadragon453 Jul 22, 2019

common/eventcontent.go Outdated Show resolved Hide resolved
Cnly added 3 commits Jul 22, 2019
Add omitempty for predecessor
Signed-off-by: Alex Chen <minecnly@gmail.com>
Comment the validation of defined creation_content fields
Signed-off-by: Alex Chen <minecnly@gmail.com>

@Cnly Cnly requested a review from anoadragon453 Jul 22, 2019

Remove duplicate comment
Signed-off-by: Alex Chen <minecnly@gmail.com>
@anoadragon453

This comment has been minimized.

Copy link
Member

commented Jul 22, 2019

Also fyi it looks like the creator field is going the way of the dodo: matrix-org/matrix-doc#2175

@Cnly

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 22, 2019

Thanks. no objections from the Dendrite perspective I think.

@anoadragon453
Copy link
Member

left a comment

lgtm

@anoadragon453 anoadragon453 merged commit 604685c into matrix-org:master Jul 24, 2019

8 checks passed

buildkite/dendrite Build #132 passed (3 minutes, 55 seconds)
Details
buildkite/dendrite/build-slash-go-1-dot-11 Passed (54 seconds)
Details
buildkite/dendrite/build-slash-go-1-dot-12 Passed (49 seconds)
Details
buildkite/dendrite/lint-slash-go-1-dot-12 Passed (1 minute, 56 seconds)
Details
buildkite/dendrite/pipeline Passed (9 seconds)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-11 Passed (1 minute, 9 seconds)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-12 Passed (55 seconds)
Details
ci/circleci: dendrite Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.