Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement event redaction #768

Open
wants to merge 17 commits into
base: master
from

Conversation

@Cnly
Copy link
Collaborator

commented Jul 27, 2019

Fixes #620.

This PR also includes a minor database fix taken from #696.

This PR doesn't provide full check on redactor's power level yet, which should be fixed at some point later, together with Dendrite's other power level TODOs. Another aspect in which it can be improved is that some similar code appearing in both roomserver and syncapi may be able to get factored out somewhere.

Signed-off-by: Alex Chen minecnly@gmail.com

Pull Request Checklist

  • I have added any new tests that need to pass to testfile as specified in docs/sytest.md
  • Pull request includes a sign off

Cnly added some commits Jul 27, 2019

Implement event redaction
Signed-off-by: Alex Chen <minecnly@gmail.com>
Fix arguments in selectEventsSQL
Signed-off-by: Alex Chen <minecnly@gmail.com>
Update gomatrixserverlib to v0.0.0-20190727114627-340519e0d9e3
Signed-off-by: Alex Chen <minecnly@gmail.com>
Implement POST version of /redact
Signed-off-by: Alex Chen <minecnly@gmail.com>
Add more sanity checks
Signed-off-by: Alex Chen <minecnly@gmail.com>
Variable and type clarifications
Signed-off-by: Alex Chen <minecnly@gmail.com>
Add missing license header
Signed-off-by: Alex Chen <minecnly@gmail.com>
Ignore error from rows.Close()
Signed-off-by: Alex Chen <minecnly@gmail.com>
Remove unnecessary sanity checks
Signed-off-by: Alex Chen <minecnly@gmail.com>
Add docs for validateRedactions
Signed-off-by: Alex Chen <minecnly@gmail.com>

@Cnly Cnly marked this pull request as ready for review Aug 1, 2019

Merge branch 'master' into event-redaction
Signed-off-by: Alex Chen <minecnly@gmail.com>

@Cnly Cnly requested a review from anoadragon453 Aug 1, 2019

Cnly added some commits Aug 3, 2019

Add newly passing test
Signed-off-by: Alex Chen <minecnly@gmail.com>
Remove obsolete TODOs
Signed-off-by: Alex Chen <minecnly@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.