Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix transaction IDs in transaction cache have global scope #772

Merged
merged 4 commits into from Aug 6, 2019

Conversation

@Cnly
Copy link
Collaborator

commented Aug 1, 2019

Fixes #756.

Signed-off-by: Alex Chen minecnly@gmail.com

Pull Request Checklist

  • I have added any new tests that need to pass to testfile as specified in docs/sytest.md
  • Pull request includes a sign off
Fix transaction IDs in txn cache have global scope
Fixes #756.

Signed-off-by: Alex Chen <minecnly@gmail.com>
@Cnly

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 1, 2019

Interestingly this allowed a new test where there's a txnID shared in SyTest to pass.

Cnly and others added some commits Aug 1, 2019

Add newly passing test
Signed-off-by: Alex Chen <minecnly@gmail.com>
@anoadragon453
Copy link
Member

left a comment

lgtm

@Cnly Cnly merged commit 66bf615 into matrix-org:master Aug 6, 2019

8 checks passed

buildkite/dendrite Build #206 passed (3 minutes, 44 seconds)
Details
buildkite/dendrite/build-slash-go-1-dot-11 Passed (56 seconds)
Details
buildkite/dendrite/build-slash-go-1-dot-12 Passed (51 seconds)
Details
buildkite/dendrite/lint-slash-go-1-dot-12 Passed (1 minute, 44 seconds)
Details
buildkite/dendrite/pipeline Passed (8 seconds)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-11 Passed (55 seconds)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-12 Passed (51 seconds)
Details
ci/circleci: dendrite Your tests passed on CircleCI!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.