Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix data race in clientapi/routing/register.go #787

Merged
merged 1 commit into from Aug 16, 2019

Conversation

@Cnly
Copy link
Collaborator

commented Aug 15, 2019

Fixes #780.

Signed-off-by: Alex Chen minecnly@gmail.com`

Pull Request Checklist

  • I have added any new tests that need to pass to testfile as specified in docs/sytest.md
  • Pull request includes a sign off
Fix data race in clientapi/routing/register.go
Signed-off-by: Alex Chen <minecnly@gmail.com>

@Cnly Cnly requested a review from anoadragon453 Aug 15, 2019

@anoadragon453
Copy link
Member

left a comment

Good catch, thanks!

@Cnly Cnly merged commit 0ed2dd0 into matrix-org:master Aug 16, 2019

8 checks passed

buildkite/dendrite Build #254 passed (5 minutes, 5 seconds)
Details
buildkite/dendrite/build-slash-go-1-dot-11 Passed (58 seconds)
Details
buildkite/dendrite/build-slash-go-1-dot-12 Passed (49 seconds)
Details
buildkite/dendrite/lint-slash-go-1-dot-12 Passed (1 minute, 50 seconds)
Details
buildkite/dendrite/pipeline Passed (8 seconds)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-11 Passed (56 seconds)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-12 Passed (56 seconds)
Details
ci/circleci: dendrite Your tests passed on CircleCI!
Details

@Cnly Cnly deleted the Cnly:fix-data-race branch Aug 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.