Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Response from /send_join now use gomatrixserverlib.RespSendJoin #796

Open
wants to merge 2 commits into
base: master
from

Conversation

@behouba
Copy link
Contributor

commented Sep 23, 2019

Signed-off-by: Kouame Behouba Manassé behouba@gmail.com

Should fix #614

Pull Request Checklist

  • I have added any new tests that need to pass to testfile as specified in docs/sytest.md
  • Pull request includes a sign off
@behouba behouba changed the title Response from /send_join now use gomatrixserverlib.RespSendJoin #614 Response from /send_join now use gomatrixserverlib.RespSendJoin Sep 23, 2019
@Cnly

This comment has been minimized.

Copy link
Collaborator

commented Sep 30, 2019

This branch is 49 commits behind matrix-org:master. Could you do a merge?

@anoadragon453

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

@Cnly have merged forward and ran CI

@Cnly

This comment has been minimized.

Copy link
Collaborator

commented Sep 30, 2019

Maybe gomatrixserverlib needs some changes? It seems RespSendJoin is missing the required field origin.

@behouba

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

@Cnly you are right, after reading the spec there is a missing origin field.

@anoadragon453

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

@behouba Would you be up for writing a PR for gomatrixserverlib to add the field?

@behouba

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

I will work on it with pleasure :)

@behouba

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

@anoadragon453 Should i close this PR?

@anoadragon453

This comment has been minimized.

Copy link
Member

commented Sep 30, 2019

@anoadragon453 Should i close this PR?

Nah, once gomatrixserverlib is updated you can change this PR to set the fields as well as update Dendrite's gomatrixserverlib's version :)

@behouba

This comment has been minimized.

Copy link
Contributor Author

commented Sep 30, 2019

Ok, great ! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.