Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectAccountDataByType return ClientEvent pointer instead of slice of ClientEvent #798

Merged
merged 4 commits into from Sep 30, 2019

Conversation

@behouba
Copy link
Contributor

commented Sep 29, 2019

Pull Request Checklist

This pull request is an attempt to fix #773.

Signed-off-by: Kouame Behouba Manassé behouba@gmail.com

  • I have added any new tests that need to pass to testfile as specified in docs/sytest.md
  • Pull request includes a sign off
…) instead of ([]gomatrixserverlib.ClientEvent, error)
Copy link
Collaborator

left a comment

Only took a glimpse, but looks pretty good. Thanks!

@behouba behouba requested a review from Cnly Sep 29, 2019
@Cnly
Cnly approved these changes Sep 30, 2019
Copy link
Collaborator

left a comment

Looks good to me & SyTest is passing on my machine. Now we'll need to wait for the CI.

@anoadragon453 anoadragon453 merged commit 49fd47c into matrix-org:master Sep 30, 2019
8 checks passed
8 checks passed
buildkite/dendrite Build #282 passed (10 minutes, 20 seconds)
Details
buildkite/dendrite/build-slash-go-1-dot-11 Passed (1 minute, 4 seconds)
Details
buildkite/dendrite/build-slash-go-1-dot-12 Passed (58 seconds)
Details
buildkite/dendrite/lint-slash-go-1-dot-12 Passed (2 minutes, 22 seconds)
Details
buildkite/dendrite/pipeline Passed (9 seconds)
Details
buildkite/dendrite/sytest-go-1-dot-11-slash-postgres-9-dot-6 Soft failed (exit status 1)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-11 Passed (1 minute, 11 seconds)
Details
buildkite/dendrite/unit-tests-slash-go-1-dot-12 Passed (51 seconds)
Details
@Cnly Cnly referenced this pull request Oct 4, 2019
2 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.