Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement removal of reactions #154

Open
Cadair opened this issue Jul 5, 2019 · 1 comment
Labels

Comments

@Cadair
Copy link
Collaborator

@Cadair Cadair commented Jul 5, 2019

Currently we add reactions in both directions but can't remove them across the bridge.

For matrix -> slack reaction removal, the issue is when we add the reaction to slack, the reactions.add slack API method doesn't return the ts of the reaction event. You would have to listen for the event to come in on the event stream.

For slack -> matrix removal, the issue is that the slack event reaction_removed also dosen't give you the ts of the reaction event, it gives you the ts of the parent event as well as the sender of the reaction and the key of the reaction. This therefore means we would have to use the not-finished-yet aggregations API to query synapse for the event ID that matched those parameters.

@Half-Shot

This comment has been minimized.

Copy link
Contributor

@Half-Shot Half-Shot commented Jul 5, 2019

See also #131

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.