New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usernames going away? #65

Closed
andrewshadura opened this Issue Jan 9, 2018 · 9 comments

Comments

Projects
None yet
2 participants
@andrewshadura

andrewshadura commented Jan 9, 2018

@erdnaxeli

This comment has been minimized.

Collaborator

erdnaxeli commented Jan 15, 2018

I think it's ok. A slack app cannot set a username when using its incoming webhook, but we are not using a slack app.

@andrewshadura

This comment has been minimized.

andrewshadura commented Jan 16, 2018

What exactly is okay? All Matrix users now look the same, they're unidentifiable.

@erdnaxeli

This comment has been minimized.

Collaborator

erdnaxeli commented Jan 16, 2018

Well, if I understand correctly the changelog, I think the bridge should still work. And I have no problem with username :s.

@andrewshadura

This comment has been minimized.

andrewshadura commented Jan 16, 2018

Well, in practice it doesn't, all messages come through with identical avatars and the same nickname, which is incoming-webhook. And it matches the behaviour the blog post described (saying that username should not be included in the messages and will be ignored at some point in future).

@erdnaxeli

This comment has been minimized.

Collaborator

erdnaxeli commented Jan 16, 2018

The blog post does not say that:

Slack apps and their bot users should not use the username field when authoring a message. The username is part of your app's configuration and will not always be settable at runtime.

And on the incoming webhook documentation:

You cannot override the default username, icon, or channel for incoming webhooks attached to Slack apps. Instead, these values will stubbornly inherit from the associated Slack app configuration.

The bridge is not an app (so far), so it should be ok. Maybe I am missing something.

@andrewshadura

This comment has been minimized.

andrewshadura commented Jan 16, 2018

In my understanding, anything that uses a webhook in fact is an app.

In any case, the bridge doesn't work properly, and I've no idea whether that can be fixed or not.

@andrewshadura

This comment has been minimized.

andrewshadura commented Jan 16, 2018

Indeed, Incoming Webhooks is an app.

Incoming WebHooks

App Info · Settings
This app was made by Slack.
Incoming Webhooks are a simple way to post messages from external sources into Slack. They make use of normal HTTP requests with a JSON payload, which includes the message and a few other optional details described later.
Message Attachments can also be used in Incoming Webhooks to display richly-formatted messages that stand out from regular chat messages.

@andrewshadura

This comment has been minimized.

andrewshadura commented Jan 16, 2018

Right, it's not yet that bad.
When I manually ran this:

curl -X POST -H 'Content-type: application/json' --data '{"text":"Jeeeej", "icon_url": "https://avatars2.githubusercontent.com/u/309253", "username": "andrewsh", }'   https://hooks.slack.com/services/SIKRITSIKRIT/ANOTHERSECRET

It works:
2018-01-16_13-15-26

When posting on Matrix, I only see this:
2018-01-16_13-15-57

@andrewshadura

This comment has been minimized.

andrewshadura commented Mar 10, 2018

It seems to be working once again:
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment