Move to yarn #685
Merged
Move to yarn #685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
AndrewFerr
requested changes
Jul 15, 2022
docs/getting_started.md
Outdated
| $ npm install | ||
| $ npm run build | ||
| $ yarn install | ||
| $ yarn build |
There was a problem hiding this comment.
Only yarn install (or just yarn) is needed, as yarn build gets run automatically by virtue of being the "prepare" script in package.json.
docs/getting_started.md
Outdated
| @@ -14,8 +14,8 @@ work for older releases and other homeservers, but configuration may vary. | |||
| ```sh | |||
| $ git clone https://github.com/matrix-org/matrix-appservice-slack.git | |||
| $ cd Matrix-appservice-slack | |||
There was a problem hiding this comment.
Aside: the M should be lower case
docs/getting_started.md
Outdated
| @@ -73,7 +73,7 @@ ever stuck, you can post a question in the | |||
| port it will send messages through (if this bridge runs on the same | |||
| machine you can use `localhost` as the `$HOST` name): | |||
|
|
|||
| `$ npm start -- -r -c config/config.yaml -u "http://$HOST:$MATRIX_PORT"` | |||
| `$ yarn start -- -r -c config/config.yaml -u "http://$HOST:$MATRIX_PORT"` | |||
There was a problem hiding this comment.
yarn [run] <script> doesn't require -- for option separation, and even dumps a warning about it:
warning From Yarn 1.0 onwards, scripts don't require "--" for options to be forwarded. In a future version, any explicit "--" will be forwarded as-is to the scripts.
package.json
Outdated
| "start": "node ./lib/app.js", | ||
| "build": "tsc --build", | ||
| "test": "npm run test:unit && npm run test:integration", | ||
| "test": "yarn run test:unit && yarn run test:integration", |
There was a problem hiding this comment.
yarn run <script> can be just yarn <script>.
Half-Shot
force-pushed
the
hs/update-appservice-bridge
branch
from
b521494
to
5d4ed48
Compare
AndrewFerr
approved these changes
Jul 15, 2022
LudvigHz
pushed a commit
to webkom/matrix-appservice-slack
that referenced
this pull request
Jul 26, 2022
* Update appservice-bridge, ping yargs * Move to yarn * changelog * Ensure we use yarn in all the places * Drop package-lock from dockerfile * Use 4.0.2 * Don't try to build in prod * Requested changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be inline with the rest of our projects.
CI will fail due to buildkite not being updated. See #688 for working CI.