Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC 1267: Interactive key verification using short authentication strings #1267

Closed
uhoreg opened this issue May 28, 2018 · 8 comments
Closed

MSC 1267: Interactive key verification using short authentication strings #1267

uhoreg opened this issue May 28, 2018 · 8 comments

Comments

@uhoreg
Copy link
Member

@uhoreg uhoreg commented May 28, 2018

Define a more user-friendly method of verifying device keys.

Documentation: https://docs.google.com/document/d/1SXmyjyNqClJ5bTHtwvp8tT1Db4pjlGVxfPQNdlQILqU/edit#

@richvdh richvdh removed the proposal-wip label Nov 7, 2018
@turt2live turt2live added the T-Core label Dec 24, 2018
@anoadragon453 anoadragon453 removed the T-Core label Jan 4, 2019
@uhoreg uhoreg changed the title Interactive Key Verification MSC 1267: Interactive key verification using short authentication strings Jan 8, 2019
@uhoreg
Copy link
Member Author

@uhoreg uhoreg commented Mar 5, 2019

@mscbot fcp merge

@mscbot
Copy link
Collaborator

@mscbot mscbot commented Mar 5, 2019

Team member @uhoreg has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@uhoreg uhoreg added the e2e label Apr 1, 2019
@turt2live turt2live added this to To add to spec in Matrix 1.0 workflow via automation May 20, 2019
@turt2live turt2live moved this from To add to spec to FCP Not Started in Matrix 1.0 workflow May 20, 2019
@dbkr
Copy link
Member

@dbkr dbkr commented May 24, 2019

Just a couple of minor things on the doc: open questions we should close and updates to the emoji that got implemented. other than that, lgtm.

@richvdh
Copy link
Member

@richvdh richvdh commented May 24, 2019

I've not worked through the cryptographic aspects of this, but from the protocol POV I'm happy. Have written a couple of questions on the doc which I'd like to see answers to over the next few days.

Also there seem to be a bunch of resolved comment threads on the doc which it would be good to close if you are happy they are addressed.

@mscbot
Copy link
Collaborator

@mscbot mscbot commented May 24, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@mscbot
Copy link
Collaborator

@mscbot mscbot commented May 30, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@turt2live turt2live self-assigned this May 31, 2019
@turt2live turt2live moved this from To add to spec to In progress in Matrix 1.0 workflow May 31, 2019
@turt2live
Copy link
Member

@turt2live turt2live commented Jun 4, 2019

Spec PR: #2072

@turt2live
Copy link
Member

@turt2live turt2live commented Jun 7, 2019

merged 🎉

@turt2live turt2live closed this Jun 7, 2019
Matrix 1.0 workflow automation moved this from In progress to Done Jun 7, 2019
@turt2live turt2live added merged and removed spec-pr-in-review labels Jun 7, 2019
@turt2live turt2live added the kind:core label Apr 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants