Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invite_room_state outside m.room.member event content #1350

Closed
njouanin opened this issue Jul 2, 2018 · 0 comments
Closed

invite_room_state outside m.room.member event content #1350

njouanin opened this issue Jul 2, 2018 · 0 comments
Labels
clarification An area where the spec could do with being more explicit
Projects
August 2018 r0

Comments

@njouanin
Copy link

njouanin commented Jul 2, 2018

Hi,
According to r0.3.0 of C2S spec, the m.room.member event can have a attribute named invite_room_state which is set outside the event content.
This is very annoying as it makes m.room.member events specific (compared to other event types), especially for strongly types languages mapping JSON to custom types (for example Java class).
Is there a reason why invite_room_state is outside the event content. If not, is it possible to move it inside ? If there's a reason, can you explain ?
Also, the specifications is not very clear concerning the role of invite_room_state:

If present, this contains an array of StrippedState Events. These events provide information on a subset of state events such as the room name.

What are StrippedState events ? What the HS is supposed to do with such events ?
@njouanin njouanin changed the title invite_room_state outside m.room.member event invite_room_state outside m.room.member event content Jul 3, 2018
@uhoreg uhoreg added the clarification An area where the spec could do with being more explicit label Jul 9, 2018
@turt2live turt2live added this to To do: client-server (prioritized) in August 2018 r0 Aug 14, 2018
turt2live added a commit to turt2live/matrix-doc that referenced this issue Aug 27, 2018
@turt2live
Move invite_room_state to the correct place in the client-server API
e9e93b0 
Fixes matrix-org#1350
@turt2live turt2live mentioned this issue Aug 27, 2018
Merged
@turt2live turt2live moved this from To do: client-server (prioritized) to In review (just the issues) in August 2018 r0 Aug 27, 2018
August 2018 r0 automation moved this from In review (just the issues) to Done (this list will be incomplete) Aug 28, 2018
RiotTranslateBot pushed a commit to RiotTranslateBot/matrix-doc that referenced this issue Aug 22, 2023
@zecakeh
Remove keyId from the server keys endpoints (matrix-org#1350)
9e45037 
* Remove keyId from the server keys endpoints

It has been deprecated forever.
Besides, the OpenAPI 3 spec doesn't allow optional path parameters.

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>

* Add newsfragment

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>

* Fix broken link

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>

* Mention MSC3938 in newfragment

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>

Signed-off-by: Kévin Commaille <zecakeh@tedomum.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clarification An area where the spec could do with being more explicit
Projects
No open projects
August 2018 r0
  
Done (this list will be incomplete)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@njouanin @uhoreg