Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity service should do lookups based on hashed 3PIDs, not plaintext ones. #2130

Closed
ara4n opened this issue Jun 14, 2019 · 2 comments · Fixed by #2134

Comments

@ara4n
Copy link
Member

commented Jun 14, 2019

There is no reason for an IS to ever handle plaintext 3PIDs when doing a lookup; from a privacy perspective we should hash them.

@Half-Shot

This comment has been minimized.

@turt2live

This comment has been minimized.

Copy link
Member

commented Jul 23, 2019

ftr, there is a reason in the case of identity servers backed by another system, such as LDAP. The identity server might not know if a user exists based on hash (as it would be compute heavy to pull all the users from the external system and hash all their identifiers at that point in time), and therefore would need the plain text address so it can more easily do the lookup.

The more general cases though should be hashed, although I question to what extent we do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.