New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spec for m.room.pinned_events #1007

Merged
merged 4 commits into from Oct 17, 2017

Conversation

Projects
None yet
4 participants
@turt2live
Member

turt2live commented Sep 29, 2017

I don't actually know if this is correct, as I can't build matrix-doc. Please let me know if I've done it wrong, and how to fix it.

Addresses #550

Add spec for m.room.pinned_events
Signed-off-by: Travis Ralston <travpc@gmail.com>
@matrixbot

This comment has been minimized.

Member

matrixbot commented Sep 29, 2017

Can one of the admins verify this patch?

@turt2live turt2live referenced this pull request Sep 29, 2017

Merged

Message/event pinning #5142

3 of 3 tasks complete
@ara4n

This comment has been minimized.

Member

ara4n commented Oct 15, 2017

the spec looks fine to me (modulo the vector-im/riot-web#5142 (comment) comment that in future we might want to consolidate pinning with general event tagging - e.g. upvoting/downvoting). @richvdh, you are probably best positioned to say if it for spec/syntax validity?

@richvdh

This comment has been minimized.

Member

richvdh commented Oct 16, 2017

@matrixbot: test this please

@richvdh

This is great, thanks!

Except it really needs linking from somewhere in the spec. https://github.com/matrix-org/matrix-doc/blob/master/specification/modules/instant_messaging.rst looks like a likely place.

Generally I also ask that people submit an entry to the changelog (https://github.com/matrix-org/matrix-doc/blob/master/changelogs/client_server.rst) along with any non-trivial PR.

.gitignore Outdated
@@ -8,3 +8,4 @@
/templating/out
*.pyc
*.swp
/env

This comment has been minimized.

@richvdh

richvdh Oct 16, 2017

Member

nit: these are sorted at the moment. Could you stick it in the right place?

turt2live added some commits Oct 17, 2017

Update instant_messaging.rst
Signed-off-by: Travis Ralston <travpc@gmail.com>
Update .gitignore
Signed-off-by: Travis Ralston <travpc@gmail.com>
Update client_server.rst
Signed-off-by: Travis Ralston <travpc@gmail.com>
@turt2live

This comment has been minimized.

Member

turt2live commented Oct 17, 2017

@richvdh updated. I have no way of testing this and am going off of what code in the area looks like, so please pardon my mistakes if they're present.

@richvdh

This comment has been minimized.

Member

richvdh commented Oct 17, 2017

This is brilliant, thank you!

(writing some notes on how to build the spec locally is on my todo list...)

@richvdh richvdh merged commit c4bcd0a into matrix-org:master Oct 17, 2017

@turt2live turt2live deleted the turt2live:travis/m.room.pinned_events branch Mar 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment