Make m.presence match what synapse returns #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Considering this is the behaviour that is embedded into most client libraries and the most popular homeserver, it should be adopted as the standard. Signed-off-by: Travis Ralston <travpc@gmail.com>
Signed-off-by: Travis Ralston <travpc@gmail.com>
|
Fixes #650 |
|
Agreed. Thanks. |
|
Probably only occured to me now that technically sender != userid in most cases since the HS overrides whatever presence might have been set by the user, although I'm not sure what you would specify the sender to be. Just seems a bit crap. |
|
@Half-Shot My argument would be the user "sent" a read receipt, even if the server decided to do it for them, therefore they are the sender. It could be argued that a |
florianjacob
added a commit
to florianjacob/ruma-events
that referenced
this pull request
Sep 1, 2018
making ruma-client more interoperable with synapse. See matrix-org/matrix-spec-proposals#1137 for the details of the spec change. Fixes https://github.com/ruma/ruma-client-api/issues/27
florianjacob
added a commit
to florianjacob/ruma-events
that referenced
this pull request
Sep 1, 2018
making ruma-client more interoperable with synapse. See matrix-org/matrix-spec-proposals#1137 for the details of the spec change. Fixes https://github.com/ruma/ruma-client-api/issues/27
RiotTranslateBot
pushed a commit
to RiotTranslateBot/matrix-doc
that referenced
this pull request
Aug 22, 2023
This might be kinda obvious, but didn't seem to be spelt out anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering this is the behaviour that is embedded into most client libraries and the most popular homeserver, it should be adopted as the standard.