New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make m.presence match what synapse returns #1137

Merged
merged 2 commits into from Mar 5, 2018

Conversation

Projects
None yet
3 participants
@turt2live
Member

turt2live commented Mar 3, 2018

Considering this is the behaviour that is embedded into most client libraries and the most popular homeserver, it should be adopted as the standard.

turt2live added some commits Mar 3, 2018

Make m.presence match what synapse returns
Considering this is the behaviour that is embedded into most client libraries and the most popular homeserver, it should be adopted as the standard.

Signed-off-by: Travis Ralston <travpc@gmail.com>
Add changelog entry for m.presence format fix
Signed-off-by: Travis Ralston <travpc@gmail.com>
@turt2live

This comment has been minimized.

Member

turt2live commented Mar 5, 2018

Fixes #650

@richvdh

This comment has been minimized.

Member

richvdh commented Mar 5, 2018

Agreed. Thanks.

@richvdh richvdh merged commit 66f434c into matrix-org:master Mar 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@Half-Shot

This comment has been minimized.

Contributor

Half-Shot commented Mar 6, 2018

Probably only occured to me now that technically sender != userid in most cases since the HS overrides whatever presence might have been set by the user, although I'm not sure what you would specify the sender to be.

Just seems a bit crap.

@turt2live turt2live deleted the turt2live:travis/m.presence branch Mar 6, 2018

@turt2live

This comment has been minimized.

Member

turt2live commented Mar 6, 2018

@Half-Shot My argument would be the user "sent" a read receipt, even if the server decided to do it for them, therefore they are the sender. It could be argued that a user_id is more clear though.

florianjacob added a commit to florianjacob/ruma-events that referenced this pull request Sep 1, 2018

Apply upcoming spec change to m.presence event representation,
making ruma-client more interoperable with synapse.
See matrix-org/matrix-doc#1137 for the details
of the spec change.
Fixes ruma/ruma-client-api#27

florianjacob added a commit to florianjacob/ruma-events that referenced this pull request Sep 1, 2018

Apply upcoming spec change to m.presence event representation,
making ruma-client more interoperable with synapse.
See matrix-org/matrix-doc#1137 for the details
of the spec change.
Fixes ruma/ruma-client-api#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment