New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec notifications key on power level event and provide @room in example #1176

Merged
merged 8 commits into from Aug 29, 2018

Conversation

3 participants
@t3chguy
Contributor

t3chguy commented Apr 15, 2018

  • needs changelog

t3chguy added some commits Apr 15, 2018

Merge branches 'master' and 'notifications/room' of github.com:matrix…
…-org/matrix-doc into notifications/room
@richvdh

This comment has been minimized.

Member

richvdh commented May 31, 2018

fixes #1101 I guess

@richvdh richvdh removed their assignment May 31, 2018

additionalProperties:
type: number
description: |-
The power level requirements for specific notification types.

This comment has been minimized.

@turt2live

turt2live Jul 3, 2018

Member

What other notification types do we have today?

@@ -14,6 +14,10 @@ Unreleased changes
- Add sticker message event definition.
(`#1158 <https://github.com/matrix-org/matrix-doc/pull/1158>`_).
- ``@room`` Notifications PL:
- Specify how to control the power level required for ``@room``.

This comment has been minimized.

@turt2live

turt2live Jul 3, 2018

Member

tbh instead of this being nested, they can be merged together

This comment has been minimized.

@turt2live

turt2live Aug 16, 2018

Member

note: since this PR was opened, the changelog format changed. Now just needs a newsfile.

@turt2live

This comment has been minimized.

Member

turt2live commented Jul 30, 2018

@t3chguy what are the chances this can be rebased for the new changelog format?

@turt2live turt2live added this to Needs review in August 2018 r0 Aug 14, 2018

@turt2live turt2live moved this from Needs review to In progress in August 2018 r0 Aug 14, 2018

@turt2live turt2live moved this from In progress to In review in August 2018 r0 Aug 14, 2018

@turt2live turt2live self-assigned this Aug 14, 2018

t3chguy added some commits Aug 16, 2018

@t3chguy t3chguy force-pushed the notifications/room branch from 4b7348e to 17a0dcc Aug 16, 2018

@t3chguy

This comment has been minimized.

Contributor

t3chguy commented Aug 16, 2018

@turt2live back at you

@turt2live

only one thing

The power level requirements for specific notification types.
This is a mapping from ``key`` to power level for that notifications key.
title: Notifications
type: object

This comment has been minimized.

@turt2live

turt2live Aug 16, 2018

Member

missing a properties declaration for room. Future versions can always add more as needed.

This comment has been minimized.

@turt2live

turt2live Aug 29, 2018

Member

... it's declared higher up

@turt2live turt2live assigned t3chguy and unassigned turt2live Aug 22, 2018

August 2018 r0 automation moved this from In review (just the PRs) to Reviewer approved Aug 29, 2018

@turt2live

LGTM - I've merged in the latest master and s/number/integer as these fields are integers, not floating point values.

@turt2live turt2live merged commit a6d42bf into master Aug 29, 2018

7 checks passed

ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

August 2018 r0 automation moved this from Reviewer approved to Done (this list will be incomplete) Aug 29, 2018

@turt2live turt2live deleted the notifications/room branch Aug 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment