Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Thirdparty Entity Lookup API #1353
Thank you for taking the time to document this! From what I can tell on a first pass it's accurate and matches real life - which is a great thing :)
I have left a number of comments about indentation of examples, spelling out words, etc. At about the halfway point I felt bad for leaving so many comments and decided to stop pointing them out - having them all fixed would be great.
It looks like the Travis build is complaining about some sort of enum mismatch: https://travis-ci.org/matrix-org/matrix-doc/builds/400400675#L747
I think I answered your schema question somewhere in here. If not, please yell at me. I don't see anything obvious that would cause Travis CI to complain, but I suspect it'll be easier to see with all the
The only other thing is the definitions should be under
definitions rather than
definitions/schema to be consistent with the c2s API.
That one went a bit too fast. I have two comments; without having those addressed, I cannot use the files to generate the client code.