New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly declare that the kick/ban reason will be on the membership event #1362

Merged
merged 3 commits into from Jul 6, 2018

Conversation

Projects
None yet
3 participants
@turt2live
Member

turt2live commented Jul 3, 2018

Fixes #798

This PR documents existing behaviour and does not attempt to improve or change the situation.

Reference: https://github.com/matrix-org/synapse/blob/53969e196004659c6a9f138f5d8abd86f4957d74/synapse/rest/client/v1/room.py#L639-L641

@@ -34,6 +34,10 @@ paths:
Kick a user from the room.
The caller must have the required power level in order to perform this operation.

This comment has been minimized.

@turt2live

turt2live Jul 3, 2018

Member

The paragraph below was added to help describe what is going on. It is an almost direct copy/paste from the "Banning users" section.

@dbkr

dbkr approved these changes Jul 4, 2018

@erikjohnston may also care

@dbkr dbkr assigned erikjohnston and unassigned dbkr Jul 4, 2018

@turt2live turt2live merged commit e1885e4 into matrix-org:master Jul 6, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@turt2live turt2live deleted the turt2live:travis/spec-reason branch Jul 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment