New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting presence requires authentication #1371

Merged
merged 4 commits into from Jul 9, 2018

Conversation

Projects
None yet
3 participants
@turt2live
Member

turt2live commented Jul 4, 2018

This PR documents existing behaviour and does not attempt to improve or change the situation.

Synapse does this:

$ curl -s https://t2l.io/_matrix/client/r0/presence/@travis:t2l.io/status
{
    "errcode": "M_MISSING_TOKEN",
    "error": "Missing access token."
}

turt2live added some commits Jul 4, 2018

@uhoreg

This comment has been minimized.

Member

uhoreg commented Jul 4, 2018

May as well also document the 403 error code that's possible (ref: https://github.com/matrix-org/synapse/blob/master/synapse/rest/client/v1/presence.py#L47..L52 assuming I'm looking at the right function). Otherwise, looks good to me.

@turt2live

This comment has been minimized.

Member

turt2live commented Jul 4, 2018

Good catch. I've included it here - please take a look.

@uhoreg

uhoreg approved these changes Jul 9, 2018

@turt2live turt2live merged commit 44db84f into matrix-org:master Jul 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@turt2live turt2live deleted the turt2live:travis/all-the-auth branch Jul 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment