New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document message formats as-is #1397

Merged
merged 2 commits into from Jul 11, 2018

Conversation

Projects
None yet
4 participants
@turt2live
Member

turt2live commented Jul 10, 2018

This is likely to later be replaced by mixins (#1225), however this is being documented now so clients aren't left in the dark.

Fixes #917

This PR documents existing behaviour and does not attempt to improve or change the situation.

turt2live added some commits Jul 10, 2018

Document message formats as-is
This is likely to later be replaced by mixins, however this is being documented now so clients aren't left in the dark.

Fixes #917
@turt2live

This comment has been minimized.

Member

turt2live commented Jul 10, 2018

This is blocked on #1389 (but can still receive review)

@turt2live

This comment has been minimized.

Member

turt2live commented Jul 10, 2018

@mujx and/or @KitsuneRal - would be nice to get your approval on this one

@KitsuneRal

Finally :) thanks!

@mujx

This comment has been minimized.

Contributor

mujx commented Jul 11, 2018

Do we have some extra info on the format of formatted_body? Is it a subset of HTML?

@t3chguy

This comment has been minimized.

Contributor

t3chguy commented Jul 11, 2018

It's what the format key specifies

@t3chguy

This comment has been minimized.

Contributor

t3chguy commented Jul 11, 2018

You're probably referring to "org.matrix.custom.html"'s formatted_body and yes that is a subset of HTML but is also a stopgap as far as I am aware

@mujx

mujx approved these changes Jul 11, 2018

@turt2live turt2live merged commit 808a82e into matrix-org:master Jul 11, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@turt2live turt2live deleted the turt2live:travis/text-format branch Jul 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment