New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify how room versioning works #1516

Merged
merged 3 commits into from Aug 24, 2018

Conversation

3 participants
@turt2live
Member

turt2live commented Aug 15, 2018

Rendered: see 'docs' commit status.

Following the process defined in MSC1426, this PR needs approval from @richvdh and @erikjohnston to ensure accuracy to the proposal.


This is the spec PR for #1425

Room version upgrades are not part of MSC1425.

Documented aspects:

  • room_version on the create event
  • creating a room with a specific version (useful for testing)
  • make_join behaviour
  • error code documentation
  • grammar of room versions

Based upon https://docs.google.com/document/d/1urKgReoHqxX8R_XtySB17dPi-DZcKhqTEL2_s895Wz0/edit

Specify how room versioning works
This is the spec PR for #1425

Room version upgrades are not part of MSC1425.

Documented aspects:
* room_version on the create event
* creating a room with a specific version (useful for testing)
* make_join behaviour
* error code documentation
* grammar of room versions

Based upon https://docs.google.com/document/d/1urKgReoHqxX8R_XtySB17dPi-DZcKhqTEL2_s895Wz0/edit

@turt2live turt2live requested review from richvdh and erikjohnston Aug 15, 2018

@richvdh richvdh referenced this pull request Aug 15, 2018

Closed

Room Versioning #1425

@turt2live turt2live added this to In review in August 2018 r0 via automation Aug 15, 2018

August 2018 r0 automation moved this from In review to Reviewer approved Aug 20, 2018

@richvdh

lgtm!

@turt2live turt2live merged commit 5f06694 into matrix-org:master Aug 24, 2018

4 checks passed

ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

August 2018 r0 automation moved this from Reviewer approved to Done (this list will be incomplete) Aug 24, 2018

@turt2live turt2live deleted the turt2live:travis/general/room-versions branch Aug 24, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment