Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix client-server event schemas: move `age`, dedupe fields #1558
Rendered: see 'docs' status check
Edit: Halfway through this PR the
This commit adds support for event schema examples to have references to help reduce the chance of fields being forgotten. This also helps reduce duplication of fields, allowing for a more consistent spec that uses the same values everywhere.
This also removes both
Finally, this replaces "localhost" in the examples with an example domain. This is really just a nitpick thing on my part where seeing a "real world" domain is preferred.
i am still a bit confused about this - in practice, a compliant server is going to show an
changed the title from
Fix client-server event schemas: remove `age`, dedupe fields
Fix client-server event schemas: move `age`, dedupe fields
Aug 29, 2018
I've gone ahead and just added the
This is primarily because application services (particularly bridges) have a very good reason to look at this field, alongside clients which do VoIP. It's worth noting that it is not a required field, however it is something that should be provided.