New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the other fields the server is expected to keep on events #1602

Merged
merged 2 commits into from Aug 31, 2018

Conversation

3 participants
@turt2live
Member

turt2live commented Aug 29, 2018

@turt2live turt2live requested a review from matrix-org/spec-core-team Aug 29, 2018

@turt2live turt2live added this to In review (just the PRs) in August 2018 r0 via automation Aug 29, 2018

@erikjohnston

This comment has been minimized.

Member

erikjohnston commented Aug 30, 2018

Should redaction really be in the CS api spec?

@richvdh

This comment has been minimized.

Member

richvdh commented Aug 30, 2018

Should redaction really be in the CS api spec?

Clients have to replicate some of this when they get an m.room.redaction event after receiving the original, so I don't think we can get rid of it from here entirely. I'm also not in favour of duplicating it across the two specs. TBH I think it would be a candidate for something to go in a completely separate "room v1" spec.

in the meantime, +1 for it being here.

- ``signatures``
- ``depth``
- ``prev_events``
- ``prev_state``

This comment has been minimized.

@richvdh

richvdh Aug 30, 2018

Member

I feel like the presence of this and membership is more of a synapse bug than anything else.

This comment has been minimized.

@turt2live

turt2live Aug 30, 2018

Member

Considering the redaction algorithm is also used for hashes, there's not much we can really do I don't think.

August 2018 r0 automation moved this from In review (just the PRs) to Reviewer approved Aug 31, 2018

@turt2live turt2live merged commit 9646d99 into matrix-org:master Aug 31, 2018

7 checks passed

ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

August 2018 r0 automation moved this from Reviewer approved to Done (this list will be incomplete) Aug 31, 2018

@turt2live turt2live deleted the turt2live:travis/general/redactions branch Aug 31, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment