New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up and flesh out all three editions of the /requestToken API #1636
Merged
Merged
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
dfaed5b
Clean up and flesh out all three editions of the /requestToken API
turt2live f3181bb
Changelog
turt2live 4bd23a9
send_attempt is no longer optional
turt2live 7f1b94c
Merge remote-tracking branch 'matrix-org/master' into travis/c2s/id-s…
turt2live a4c2b2b
General clarity and spelling for the requestToken APIs
turt2live 63fdd72
Fix error description on /account/3pid/email/requestToken
turt2live 60dd923
Don't explain how the IS might accept a 3pid
turt2live 5bb7eca
English
turt2live 824ce22
Add additional clarity to the requestToken errors
turt2live 1261da2
Fix wording for the homeserver not allowing a particular 3pid
turt2live a1f655e
Fix more error wording
turt2live File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this file called administrative_contact.yaml and "Matrix Client-Server Account Administrative Contact API"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
History says 2015 would have an answer, but unfortunately I don't: c6e0322
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it was illicitonion being weird, presumably contorting to differentiate it from 3pid management on the IS. i'd call it homeserver_3pid_mappings.yaml or something, but it's not a blocker for the review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or just account_3pid.yaml, given it describes the /account/3pid endpoints.