Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Spec lazy_load_members and include_redundant_members #1758
It just occurred to me that we probably will need a separate section in the spec that explains how lazy-loading works from clients' standpoint (mostly reworded sections of https://docs.google.com/document/d/11yn-mAkYll10RJpN0mkYEVqraTbU3U4eQx9MNrzqX1U/edit#heading=h.q5mz9uiufb2g). This also covers MSC688 and MSC1337 though. I see 3 ways to do it:
left a comment
This generally LGTM, though it seems we've lost a paragraph from https://github.com/matrix-org/matrix-doc/pull/1287/files#diff-0365f42e14699ef8c27554ce3860f18fR137 which seemed useful?
Also, as I note on #1337, that's still in proposal stage, so I certainly wouldn't advise rolling that in here right now.
Dec 24, 2018
7 checks passed
So, i only just got to review this (sorry for lag). Whilst it correctly describes the original intention of LL, it should probably be reworded slightly to reflect the current reality, which is that LL only kicks in for initial sync if enabled. Gappy incremental syncs currently do include membership changes which happened during the gap, otherwise a client who wished to track the full membership of the room (for tab-complete, typing notifs etc) would have to do a full /members sync after every incremental sync... which ends up being worse than non-LL behaviour. The 'correct' solution is to provide an incremental dialect of /members, but that doesn't exist yet. See vector-im/riot-web#7211 (comment) for more details.
Also, we need to be explicit that you see yourself in LL members (even if you're not speaking in the room).
I guess these should go in a separate PR?