New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC1797: Proposal for more granular profile error codes #1797

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@turt2live
Copy link
Member

turt2live commented Jan 11, 2019

@turt2live turt2live changed the title Proposal for more granular profile error codes MSC1797: Proposal for more granular profile error codes Jan 11, 2019

turt2live added a commit to matrix-org/matrix-react-sdk that referenced this pull request Jan 11, 2019

Give a route for retrying invites for users which may not exist
Fixes vector-im/riot-web#7922

This supports the current style of errors (M_NOT_FOUND) as well as the errors presented by MSC1797: matrix-org/matrix-doc#1797
@jryans

This comment has been minimized.

Copy link
Contributor

jryans commented Jan 11, 2019

This proposal makes sense to me.

@ara4n

This comment has been minimized.

Copy link
Member

ara4n commented Jan 11, 2019

lgtm other than the quibble on UNKNOWN wording

@Half-Shot
Copy link
Contributor

Half-Shot left a comment

Other than M_PROFILE_UNDISCLOSED, this proposal seems sane.

Show resolved Hide resolved proposals/1797-profile-error-codes.md

@richvdh richvdh self-requested a review Jan 14, 2019

@Half-Shot
Copy link
Contributor

Half-Shot left a comment

Concerns addressed.

@richvdh richvdh removed their request for review Jan 14, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment