Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the recommendations for "transferable state" #1875

Merged
merged 4 commits into from Feb 18, 2019

Conversation

Projects
None yet
3 participants
@turt2live
Copy link
Member

commented Feb 11, 2019

Fixes #1843

Rationale for removing the text from the YAML part: this already appears in the module, so there's no point in duplicating efforts here.

@turt2live turt2live requested a review from matrix-org/spec-core-team Feb 11, 2019

@turt2live turt2live force-pushed the travis/clarify-upgrades branch from c9e995d to ef13aef Feb 11, 2019

turt2live added some commits Feb 11, 2019

@Half-Shot

This comment has been minimized.

Copy link
Contributor

commented Feb 11, 2019

Do you want to mention the rationale for not doing membership / sender sensitive events?

@Half-Shot
Copy link
Contributor

left a comment

Definitely clears up my questions around room upgrades. Thank you :)

@richvdh
Copy link
Member

left a comment

lgtm

@turt2live turt2live merged commit 49119ed into master Feb 18, 2019

7 checks passed

ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

@turt2live turt2live deleted the travis/clarify-upgrades branch Feb 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.