Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for the #1865 #1889

Merged
merged 4 commits into from Feb 28, 2019

Conversation

Projects
None yet
4 participants
@ma1uta
Copy link
Contributor

commented Feb 15, 2019

Add the m.push_rules schema.

It needs to check carefully the schema.

Signed-off-by: Anatoly Sablin sablintolya@gmail.com

@turt2live turt2live requested review from turt2live and matrix-org/spec-core-team and removed request for turt2live Feb 16, 2019

@richvdh
Copy link
Member

left a comment

looks plausible to me, but it's a shame we're directly duplicating the definitions from api/client-server/definitions/push_ruleset.yaml etc. @turt2live: do you know if there is a way these could be shared to save duplication?

@turt2live

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

Using $ref at every available opportunity is the best deduplication approach. PDUs in the s2s spec are a great example of this.

@turt2live turt2live removed their assignment Feb 21, 2019

@richvdh

This comment has been minimized.

Copy link
Member

commented Feb 21, 2019

Ah yes. there are plenty of examples of APIs which refer to event schemas.

@ma1uta: could you rework this to remove the duplication?

@ma1uta

This comment has been minimized.

Copy link
Contributor Author

commented Feb 24, 2019

@richvdh done.

@turt2live

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

A changelog (clarification) and this is ready to merge, I guess :)

@ma1uta

This comment has been minimized.

Copy link
Contributor Author

commented Feb 28, 2019

@richvdh @turt2live @KitsuneRal done. I hope this is enough to merge :)

@turt2live

This comment has been minimized.

Copy link
Member

commented Feb 28, 2019

Lots of green checkmarks compels me to merge this. Thanks for the PR!

@turt2live turt2live merged commit c08d223 into matrix-org:master Feb 28, 2019

7 checks passed

ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.