Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E typo fix in spec #1933

Merged
merged 2 commits into from Mar 18, 2019

Conversation

Projects
None yet
3 participants
@Vikingat-RAGE
Copy link
Contributor

commented Mar 18, 2019

@turt2live
Copy link
Member

left a comment

I think this is backwards, surely key and key_opts are the true values and the spelling mistake is in the example?

Also please take a look at the CONTRIBUTING.rst

@Vikingat-RAGE

This comment has been minimized.

Copy link
Contributor Author

commented Mar 18, 2019

This is incorrect. If you look at the decrypted source of a message sent by a Riot.im client it is to the changes I specified.
image

@uhoreg

This comment has been minimized.

Copy link
Member

commented Mar 18, 2019

kty and key_ops is correct; they're from JWK

@turt2live
Copy link
Member

left a comment

thanks :)

It bothers me that the fields look weird, but the experts say they are correct.

@turt2live turt2live merged commit fa541fd into matrix-org:master Mar 18, 2019

7 checks passed

ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.