Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC1957: Integration manager discovery #1957

Merged
merged 13 commits into from Aug 26, 2019
Merged

Conversation

@turt2live
Copy link
Member

@turt2live turt2live commented Apr 8, 2019

Rendered
Upstream proposal: MSC1956 - Integrations API
Discussion room: #msc-integrations-api:t2bot.io


This is being contributed under the hat of "author of Dimension":

Signed-off-by: Travis Ralston <travis@t2bot.io>
@turt2live turt2live changed the title Proposal for integration manager discovery MSC1957: Integration manager discovery Apr 8, 2019
Co-Authored-By: turt2live <travpc@gmail.com>
turt2live added a commit to matrix-org/matrix-react-sdk that referenced this issue Aug 9, 2019
For vector-im/element-web#4913 / vector-im/element-web#10161

Relies on the structure defined by [MSC1957](matrix-org/matrix-doc#1957)

This is just the bit of code to parse the user's widgets (while watching for changes) and allow for it to be the default manager.
Copy link
Member

@jaywink jaywink left a comment

This looks all in all really good 👍

@turt2live
Copy link
Member Author

@turt2live turt2live commented Aug 12, 2019

For the client authors:

@mscbot fcp merge

@mscbot
Copy link
Collaborator

@mscbot mscbot commented Aug 12, 2019

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@turt2live
Copy link
Member Author

@turt2live turt2live commented Aug 14, 2019

Partial implementation: matrix-org/matrix-react-sdk#3308

Copy link
Member

@richvdh richvdh left a comment

no objections from me

@mscbot reviewed

mechanism. The added optional fields, which should not affect a client's ability to log a user in, are:
```json
{
"m.integrations": {
Copy link
Member

@richvdh richvdh Aug 16, 2019

ok, why a managers key within m.integrations, rather than m.integration_managers ?

Copy link
Member Author

@turt2live turt2live Aug 16, 2019

Future expansion is really the only answer I have here. The other thing would be vague and not thought out things like possibly decentralized integrations, whatever that means.

proposals/1957-integrations-discovery.md Outdated Show resolved Hide resolved
proposals/1957-integrations-discovery.md Outdated Show resolved Hide resolved
@jryans jryans added the phase:2 label Aug 16, 2019
@mscbot
Copy link
Collaborator

@mscbot mscbot commented Aug 26, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@turt2live turt2live merged commit 0265817 into master Aug 26, 2019
8 checks passed
@turt2live turt2live deleted the travis/msc/integrations/discovery branch Aug 26, 2019
@turt2live turt2live self-assigned this Aug 26, 2019
@jaywink
Copy link
Member

@jaywink jaywink commented Aug 30, 2019

This is now implemented and deployed in Scalar as well.

@manuroe manuroe mentioned this pull request Oct 1, 2019
5 tasks
@manuroe manuroe mentioned this pull request Oct 1, 2019
5 tasks
aaronraimist added a commit to aaronraimist/matrix-docker-ansible-deploy that referenced this issue Dec 5, 2019
matrix-org/matrix-doc#1957

Yay Riot iOS now supports integration manager discovery!
@turt2live turt2live mentioned this pull request Sep 2, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants