Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing punctuation #1991

Merged
merged 2 commits into from May 8, 2019

Conversation

Projects
None yet
2 participants
@anoadragon453
Copy link
Member

commented May 8, 2019

Other small sentences are postfixed with a period. Add period to keep consistency.

@turt2live
Copy link
Member

left a comment

please add a changelog entry which has words that resemble https://github.com/matrix-org/matrix-doc/blob/master/changelogs/client_server/newsfragments/1838.clarification (except in the right directories)

@anoadragon453

This comment has been minimized.

Copy link
Member Author

commented May 8, 2019

I've added a changelog with similar texts in both cs and ss directories, but will that still merge together? Should they be slightly different?

@turt2live

This comment has been minimized.

Copy link
Member

commented May 8, 2019

They merge together in their respective specifications:
image

This is the first instance of the s2s spec getting it, so it'll be lonely for now.

@turt2live turt2live merged commit 7e093e9 into master May 8, 2019

8 checks passed

buildkite/matrix-doc Build #41 passed (55 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

@anoadragon453 anoadragon453 deleted the anoa/missing_punctuation2 branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.