Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix body formatting #2003

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@afranke
Copy link

commented May 19, 2019

  • body and formatted_body were inconsistent
  • the current markdown translation is to a strong tag, not b
Fix body formatting
* `body` and `formatted_body` were inconsistent
* the current markdown translation is to a strong tag, not b
@turt2live

This comment has been minimized.

Copy link
Member

commented May 19, 2019

The body doesn't necessarily represent markdown. It represents the plain text version of the message.

@afranke

This comment has been minimized.

Copy link
Author

commented May 23, 2019

That’s fair enough. I couldn’t find a way to end up with a similar situation as the one described here however. I tried with Riot and tested several variations of a message, but I wasn’t able to send a message that had the same body/formatted_body as the given example. So maybe it should still be changed to match more closely what would actually happen in the wild?

@turt2live

This comment has been minimized.

Copy link
Member

commented May 23, 2019

Riot tries to be helpful by sending the markdown. I'm not entirely convinced that we need to imply that all clients support markdown in the spec though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.