Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix third party signed definitions for join APIs #2025

Merged
merged 2 commits into from Jun 5, 2019

Conversation

Projects
None yet
2 participants
@turt2live
Copy link
Member

commented May 26, 2019

Fixes #1978

turt2live added some commits May 26, 2019

@turt2live turt2live requested a review from matrix-org/spec-core-team May 26, 2019

@turt2live

This comment has been minimized.

Copy link
Member Author

commented May 26, 2019

For reference: the third_party_signed object is passed down through Synapse here and here which then gets passed straight through here. Finally, the sender property is read here - an indicator it does not expect it to be under signed.

@dbkr

dbkr approved these changes Jun 5, 2019

@turt2live turt2live merged commit aa110b2 into master Jun 5, 2019

8 checks passed

buildkite/matrix-doc Build #96 passed (1 minute, 7 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

@turt2live turt2live deleted the travis/1.0/3rdpartysigned branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.