Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server notices support #2026

Merged
merged 2 commits into from May 28, 2019

Conversation

Projects
None yet
2 participants
@turt2live
Copy link
Member

commented May 27, 2019

As per MSC1452

Fixes #1254

Although MSC1452 focuses on just the warnings part of the server notices, the base for notices has not been established in the spec. This commit adds the needed support to be able to handle notices.

No intentional divergences from the proposal are included in this changeset. There are a few additions which are used in practice although not defined in the proposal, such as who is responsible for aesthetics, sending notices, and other misc rules.

@@ -1,7 +1,14 @@
{% import 'tables.tmpl' as tables -%}

{% if (event.type_with_msgtype) %}

This comment has been minimized.

Copy link
@turt2live

turt2live May 27, 2019

Author Member

This is so we can work around a backlink problem where it was trying to make the link m.room.message but that was defined earlier in the spec. Instead, we append the msgtype so that it is clear what event we're representing in the table of contents and avoid backlink errors.

Add server notices support
As per [MSC1452](#1452) 

Fixes #1254

Although MSC1452 focuses on just the warnings part of the server notices, the base for notices has not been established in the spec. This commit adds the needed support to be able to handle notices.

No intentional divergences from the proposal are included in this changeset. There are a few additions which are used in practice although not defined in the proposal, such as who is responsible for aesthetics, sending notices, and other misc rules.

@turt2live turt2live force-pushed the travis/1.0/msc1452-server-notices branch from e78b567 to 5eea4a4 May 27, 2019

@turt2live turt2live requested a review from matrix-org/spec-core-team May 27, 2019

@KitsuneRal
Copy link
Member

left a comment

Overall LGTM; just one nitpick in the wider context of the spec.

Show resolved Hide resolved specification/modules/server_notices.rst

@turt2live turt2live requested a review from KitsuneRal May 28, 2019

@turt2live turt2live merged commit bf8ca3a into master May 28, 2019

8 checks passed

buildkite/matrix-doc Build #117 passed (55 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

@turt2live turt2live deleted the travis/1.0/msc1452-server-notices branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.