Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec MSISDN UIA support #2030

Merged
merged 1 commit into from Jun 6, 2019

Conversation

Projects
None yet
2 participants
@turt2live
Copy link
Member

commented May 27, 2019

Fixes #1702

1702 describes the lack of bind_msisdn parameter, however the whole login type was missing from UIA.

Spec MSISDN UIA support
Fixes #1702

1702 describes the lack of `bind_msisdn` parameter, however the whole login type was missing from UIA.

@turt2live turt2live requested a review from matrix-org/spec-core-team May 27, 2019

@dbkr
Copy link
Member

left a comment

otherwise lgtm

Authentication is supported by authorising a phone number with an identity
server.

Prior to submitting this, the client should authenticate with an identity

This comment has been minimized.

Copy link
@dbkr

dbkr Jun 5, 2019

Member

This is probably a bit misleading since, whilst the client could contact the IS directly to auth, in normal cases they would be going via the HS (ie. using one of the HS's proxy requestToken endpoints).

This comment has been minimized.

Copy link
@turt2live

turt2live Jun 5, 2019

Author Member

This is largely copied from the email auth above, and both headings do say "identity server" - given the spec expects the homeserver to proxy, I think this is fine?

At least until #2078 changes all of this.

This comment has been minimized.

Copy link
@dbkr

dbkr Jun 6, 2019

Member

Fair enough

@turt2live turt2live requested a review from dbkr Jun 5, 2019

@dbkr

dbkr approved these changes Jun 6, 2019

Authentication is supported by authorising a phone number with an identity
server.

Prior to submitting this, the client should authenticate with an identity

This comment has been minimized.

Copy link
@dbkr

dbkr Jun 6, 2019

Member

Fair enough

@turt2live turt2live merged commit e1266b8 into master Jun 6, 2019

8 checks passed

buildkite/matrix-doc Build #104 passed (57 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

@turt2live turt2live deleted the travis/1.0/bind-msisdn branch Jun 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.