Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing reason property to m.call.hangup #2031

Merged
merged 2 commits into from May 28, 2019

Conversation

Projects
None yet
2 participants
@turt2live
Copy link
Member

commented May 27, 2019

Fixes #1689

@turt2live turt2live requested a review from matrix-org/spec-core-team May 27, 2019

@@ -1,6 +1,6 @@
{

This comment has been minimized.

Copy link
@turt2live

turt2live May 27, 2019

Author Member

editor's note: ewwwww JSON definition

@uhoreg
Copy link
Member

left a comment

Suggested possible improvement, but lgtm otherwise.

Show resolved Hide resolved event-schemas/schema/m.call.hangup Outdated

@turt2live turt2live requested a review from uhoreg May 28, 2019

@uhoreg

uhoreg approved these changes May 28, 2019

@turt2live turt2live merged commit 2cf00fc into master May 28, 2019

8 checks passed

buildkite/matrix-doc Build #116 passed (57 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

@turt2live turt2live deleted the travis/1.0/voip-hangup branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.