Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how redactions affect room state #2032

Merged
merged 4 commits into from May 28, 2019

Conversation

Projects
None yet
3 participants
@turt2live
Copy link
Member

commented May 27, 2019

Fixes #1726

@turt2live turt2live requested a review from matrix-org/spec-core-team May 27, 2019

@uhoreg
Copy link
Member

left a comment

The change looks fine in documenting those two examples, but it doesn't explain how to figure out the behaviour of other redacted events. I'm guessing that the general rule is that a redacted state event behaves the same as if a state event with the same contents as the redacted event were sent to the room. And any required fields are set to the appropriate empty value (e.g. empty string if the field is a string, empty array if the field is an array). Hence a redacted topic event behaves just like a topic event with topic set to the empty string.

@turt2live

This comment has been minimized.

Copy link
Member Author

commented May 28, 2019

Yup, exactly that - will try and add more words to clarify that.

@turt2live turt2live requested a review from uhoreg May 28, 2019

Update specification/client_server_api.rst
Co-Authored-By: Kitsune Ral <Kitsune-Ral@users.sf.net>
@uhoreg

uhoreg approved these changes May 28, 2019

Copy link
Member

left a comment

little nitpick, but otherwise lgtm

Show resolved Hide resolved specification/client_server_api.rst Outdated
Update specification/client_server_api.rst
Co-Authored-By: Hubert Chathi <hubert@uhoreg.ca>

@turt2live turt2live merged commit a8f6169 into master May 28, 2019

8 checks passed

buildkite/matrix-doc Build #133 passed (58 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

@turt2live turt2live deleted the travis/1.0/redaction-effects branch May 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.