Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify that UIA stages cannot be attempted twice #2054

Merged
merged 2 commits into from Jun 7, 2019

Conversation

Projects
None yet
2 participants
@turt2live
Copy link
Member

commented May 30, 2019

Fixes #1987

Note: Synapse currently does not care, however the spirit of the text in the spec implies that completed == done forever, so we're just reinforcing it here.

Clarify that UIA stages cannot be attempted twice
Fixes #1987

Note: Synapse currently does not care, however the spirit of the text in the spec implies that completed == done forever, so we're just reinforcing it here.

@turt2live turt2live requested a review from matrix-org/spec-core-team May 30, 2019


The client then chooses a flow and attempts to complete one of the stages. It
The client then chooses a flow and attempts to complete the first stage. It

This comment has been minimized.

Copy link
@turt2live

turt2live May 30, 2019

Author Member

This was missed in #2042

This is a session identifier that the client must pass back to the home
server, if one is provided, in subsequent attempts to authenticate in the same
API call.
This is a session identifier that the client must pass back to the homeserver,

This comment has been minimized.

Copy link
@turt2live

turt2live May 30, 2019

Author Member

this is s/home server/homeserver

@turt2live turt2live requested a review from dbkr Jun 5, 2019

@dbkr

dbkr approved these changes Jun 7, 2019

@turt2live turt2live merged commit f4e8585 into master Jun 7, 2019

8 checks passed

buildkite/matrix-doc Build #237 passed (54 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

@turt2live turt2live deleted the travis/1.0/uia-clarifications branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.