Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a table to show how changes in membership should be interpreted #2056

Merged
merged 2 commits into from Jun 5, 2019

Conversation

Projects
None yet
3 participants
@turt2live
Copy link
Member

commented May 30, 2019

Fixes #876

@turt2live turt2live requested a review from matrix-org/spec-core-team May 30, 2019

@uhoreg
Copy link
Member

left a comment

I disagree with one of the table cells, but otherwise lgtm

Show resolved Hide resolved event-schemas/schema/m.room.member Outdated

@turt2live turt2live self-assigned this May 30, 2019

Fix incorrect state of leave->leave
As mentioned in PR review, it is possible for moderators in a room to race at kicking someone, resulting in multiple leave events.

@turt2live turt2live requested a review from uhoreg May 30, 2019

@turt2live turt2live removed their assignment May 30, 2019

@KitsuneRal
Copy link
Member

left a comment

Fine with the contents, but have a suggestion on the formatting.


"","to ``invite``","to ``join``","to ``leave``","to ``ban``","to ``knock``"
"from ``invite``","No change.","User joined the room.","If the ``state_key`` is the same as the ``sender``, the user rejected the invite. Otherwise, the ``state_key`` user had their invite revoked.","User was banned.","Not implemented."
"from ``join``","Must never happen.","``displayname`` or ``avatar_url`` changed.","If the ``state_key`` is the same as the ``sender``, the user left. Otherwise, the ``state_key`` user was kicked.","User was kicked and banned.","Not implemented."

This comment has been minimized.

Copy link
@KitsuneRal

KitsuneRal May 31, 2019

Member

Can we make two separate columns for state_key == sender and state_key != sender for transitions to leave? Should be a bit more structured and easy to consume.
Also: probably just drop knock from the table for now?

This comment has been minimized.

Copy link
@turt2live

turt2live May 31, 2019

Author Member

I'd rather not split it into more columns as the rendering is already pretty messy.

I also think that knock should be here to reinforce that it doesn't do anything.

@uhoreg

uhoreg approved these changes May 31, 2019

@turt2live turt2live merged commit 9ac89cc into master Jun 5, 2019

8 checks passed

buildkite/matrix-doc Build #164 passed (1 minute)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

@turt2live turt2live deleted the travis/1.0/membership-table branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.