Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify exactly what StrippedState is #2067

Merged
merged 5 commits into from Jun 7, 2019

Conversation

Projects
None yet
3 participants
@turt2live
Copy link
Member

commented Jun 2, 2019

Fixes #2066

The expectation everywhere is that the sender is required. /initialSync references StrippedState through a m.room.member event reference, and does not need editing.

Clarify exactly what StrippedState is
Fixes #2066

The expectation everywhere is that the `sender` is required. `/initialSync` references StrippedState through a `m.room.member` event reference, and does not need editing.

@turt2live turt2live added the Matrix 1.0 label Jun 2, 2019

@turt2live turt2live requested a review from matrix-org/spec-core-team Jun 2, 2019

@KitsuneRal
Copy link
Member

left a comment

LGTM from client-server perspective.

@turt2live

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

requesting review for the server-side (which is just a passthrough)

@turt2live turt2live requested a review from matrix-org/spec-core-team Jun 5, 2019

@richvdh

richvdh approved these changes Jun 7, 2019

@turt2live turt2live merged commit 70da564 into master Jun 7, 2019

8 checks passed

buildkite/matrix-doc Build #178 passed (1 minute, 7 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

@turt2live turt2live deleted the travis/1.0/stripped-state branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.