Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSC2078: Sending Third-Party Request Tokens via the Homeserver #2078

Merged
merged 18 commits into from Jun 10, 2019

Conversation

@anoadragon453
Copy link
Member

commented Jun 5, 2019

Rendered

Spec PR is here: #2101

This reverts commit c9711ac.
proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
@anoadragon453

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

Seeing as people mostly agree about the content, I'm going to propose FCP.

@mscbot fcp merge

@anoadragon453

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

@mscbot fcp merge

Edit: helps if you add the label

@turt2live

This comment has been minimized.

Copy link
Member

commented Jun 5, 2019

@mscbot fcp merge

@mscbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

Team member @turt2live has proposed to merge this. The next step is review by the rest of the tagged people:

No concerns currently listed.

Once a majority of reviewers approve (and none object), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

Co-Authored-By: Hubert Chathi <hubert@uhoreg.ca>
@mscbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 5, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@turt2live turt2live added this to To add to spec in Matrix 1.0 workflow via automation Jun 5, 2019
@turt2live turt2live self-requested a review Jun 5, 2019
Copy link
Member

left a comment

also please resolve comment threads that are no longer relevant to make the timeline smaller.

proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
proposals/2078-homeserver-password-resets.md Outdated Show resolved Hide resolved
@turt2live

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

It seems like it's too late to mention it at this point, however this is a breaking change for clients. Older clients which happily continue using /r0/.../requestToken will be unaware of the new field, leading them to be non-compliant because they'll say "go check your email and click the link" instead of "enter the token from your email".

I don't really know how to fix this without bumping the endpoint version, which is non-trivial for the client-server API.

Just highlighting this as a point of documentation, rather than blocking the whole 1.0 on it. It's certainly not the first time we've broken compatibility between minor versions of the spec, however I strongly suggest this be the last time we ever do this.

@mscbot

This comment has been minimized.

Copy link
Collaborator

commented Jun 10, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

@turt2live turt2live merged commit fc1d8f1 into master Jun 10, 2019
8 checks passed
8 checks passed
buildkite/matrix-doc Build #251 passed (59 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details
Homeserver Task Board automation moved this from In progress to Done Jun 10, 2019
@anoadragon453 anoadragon453 deleted the anoa/msc2078 branch Jun 10, 2019
@turt2live

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

merged 🎉

@turt2live turt2live added merged and removed spec-pr-in-review labels Jun 11, 2019
@turt2live turt2live moved this from In progress to Done in Matrix 1.0 workflow Jun 11, 2019
manuroe added a commit to matrix-org/matrix-ios-kit that referenced this pull request Oct 8, 2019
This implements ([MSC2078](matrix-org/matrix-doc#2078)).
This is a quick c+p from matrix-org/matrix-ios-sdk#728.
We will completely remove MXK3PID when refactoring login/registration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.