Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify some of the common concepts for Matrix in the index #2097

Merged
merged 3 commits into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@turt2live
Copy link
Member

commented Jun 6, 2019

See #2061
Fixes #1468
Fixes #1528

The section is not referenced by the specifications yet - they do a fairly good job of explaining it over and over. In future, it would be good to point all the references to the index.

Note: This does not attempt to solve trailing slashes for all endpoints, just the one mentioned in #2061. See #2107 for more details.

Specify some of the common concepts for Matrix in the index
See #2061
Fixes #1468
Fixes #1528

The section is not referenced by the specifications yet - they do a fairly good job of explaining it over and over. In future, it would be good to point all the references to the index.

@turt2live turt2live added the Matrix 1.0 label Jun 6, 2019

@turt2live turt2live requested a review from matrix-org/spec-core-team Jun 6, 2019

@@ -0,0 +1 @@
Clarify that the trailing slash is optional on ``/keys/*`` endpoints when no key ID is requested.

This comment has been minimized.

Copy link
@erikjohnston

erikjohnston Jun 10, 2019

Member

This doesn't match PR description? Are these changes lost?

This comment has been minimized.

Copy link
@turt2live

turt2live Jun 10, 2019

Author Member

The changes are bundled into this PR. It's just a bit awkward because the meat of the PR isn't in the s2s spec, so the changelog is tightly scoped.

Show resolved Hide resolved specification/index.rst Outdated
Show resolved Hide resolved specification/index.rst Outdated
Show resolved Hide resolved specification/index.rst Outdated
Show resolved Hide resolved specification/index.rst Outdated

@turt2live turt2live requested review from erikjohnston and ara4n Jun 10, 2019

@turt2live

This comment has been minimized.

Copy link
Member Author

commented Jun 10, 2019

(will accept a checkmark from either of you btw)

@turt2live turt2live merged commit b7378a8 into master Jun 11, 2019

8 checks passed

buildkite/matrix-doc Build #299 passed (52 seconds)
Details
ci/circleci: build-dev-scripts Your tests passed on CircleCI!
Details
ci/circleci: build-docs Your tests passed on CircleCI!
Details
ci/circleci: build-swagger Your tests passed on CircleCI!
Details
ci/circleci: check-docs Your tests passed on CircleCI!
Details
ci/circleci: validate-docs Your tests passed on CircleCI!
Details
docs Click details to preview the HTML documentation.
Details
swagger Click to preview the swagger build.
Details

@turt2live turt2live deleted the travis/1.0/common-themes branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.